Skip to content

[Snippets] Add error handling to rewrite-site-links.mdx #23075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2025
Merged

[Snippets] Add error handling to rewrite-site-links.mdx #23075

merged 2 commits into from
Jun 17, 2025

Conversation

@pedrosousa
Copy link
Contributor

@pedrosousa pedrosousa commented Jun 17, 2025

Summary

Closes #23067.

@pedrosousa pedrosousa requested a review from a team as a code owner June 17, 2025 16:19
@github-actions github-actions bot added size/xs product:rules Related to rules labels Jun 17, 2025
@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Jun 17, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.

PR Change Summary

Enhanced error handling in the rewrite-site-links documentation to ensure proper response validation.

  • Added checks for the presence of 'Content-Type' header in the response
  • Implemented validation for the 'Content-Type' header to ensure it is a string
  • Ensured that non-HTML responses are passed through without transformation

Modified Files

  • src/content/docs/rules/snippets/examples/rewrite-site-links.mdx
How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2025

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/docs/rules/ @pedrosousa, @cloudflare/pcx-technical-writing

pedrosousa
pedrosousa commented Jun 17, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2025

Preview URL: https://c9ae0b6c.preview.developers.cloudflare.com
Preview Branch URL: https://pedro-issue23067-snippets-error-handling.preview.developers.cloudflare.com

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/rules/snippets/examples/rewrite-site-links/ https://pedro-issue23067-snippets-error-handling.preview.developers.cloudflare.com/rules/snippets/examples/rewrite-site-links/

@pedrosousa pedrosousa merged commit 08a0381 into production Jun 17, 2025
11 checks passed
@pedrosousa pedrosousa deleted the pedro/issue23067-snippets-error-handling branch June 17, 2025 17:39
sdnts pushed a commit to sdnts/cloudflare-docs that referenced this pull request Jul 24, 2025
@pedrosousa @sdnts
[Snippets] Add error handling to rewrite-site-links.mdx (cloudflare#2…
90a8769 
…3075)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marciocloudflare marciocloudflare marciocloudflare approved these changes

Assignees

No one assigned

Labels

product:rules Related to rules size/xs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Snippets "Rewrite links on HTML pages" example is missing headers validation

2 participants

@pedrosousa @marciocloudflare